Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct remote centroids path in clustering compaction #39398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correct remote centroids path in clustering compaction #39398

wants to merge 1 commit into from

Conversation

chasingegg
Copy link
Contributor

issue: #39353
The path was modified unintentionally, change it back.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 17, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 17, 2025
@chasingegg chasingegg mentioned this pull request Jan 17, 2025
Open
@xiaocai2333
Copy link
Contributor

/lgtm

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (64feeb0) to head (06f45e6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/clustering/KmeansClustering.h 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39398      +/-   ##
==========================================
- Coverage   81.01%   81.00%   -0.01%     
==========================================
  Files        1407     1408       +1     
  Lines      198528   198562      +34     
==========================================
+ Hits       160843   160853      +10     
- Misses      32029    32056      +27     
+ Partials     5656     5653       -3
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.47% <0.00%> (-0.01%) ⬇️
Go 82.94% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/clustering/KmeansClustering.h 0.00% <0.00%> (ø)

... and 41 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@xiaocai2333 xiaocai2333

Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chasingegg @sre-ci-robot @xiaocai2333